search

terraform-community-modules / tf_aws_vpc

[DEPRECATED] Use https://github.com/terraform-aws-modules/terraform-aws-vpc
Other
210 stars 203 forks source link

enabling Flow Logs #64

Closed afeld closed 7 years ago

afeld commented 7 years ago

Having flow logs enabled is useful for troubleshooting connection issues in the VPC. Thoughts about making it configurable as part of the module? Happy to submit a pull request with a variation of the Terraform example, if there's interest. Thanks!

antonbabenko commented 7 years ago

Absolutely! You are welcome to submit a PR.

afeld commented 7 years ago

Hmm, there doesn't seem to be a good way to make it conditional, and I assume it's not desirable to include it for everyone, right?

afeld commented 7 years ago

Anyway, created a module for it:

https://github.com/GSA/terraform-vpc-flow-log

More than happy to transfer to @terraform-aws-modules if there's interest.

antonbabenko commented 7 years ago

Good work with VPC flow log and I agree that it would be a great addition to https://github.com/terraform-aws-modules/terraform-aws-vpc.

VPC flow log is a single VPC resource with several parameters. It can be merged into VPC module rather easily.

I have made an issue with some details provided - https://github.com/terraform-aws-modules/terraform-aws-vpc/issues/23. Please tell me there if you have questions.