terraform-community-providers / terraform-provider-railway

Terraform provider for railway.app
https://registry.terraform.io/providers/terraform-community-providers/railway/latest/docs
Mozilla Public License 2.0
22 stars 1 forks source link

Private docker images support #26

Closed wertlex closed 2 months ago

wertlex commented 3 months ago

Hey guys!

Recently introduced Private docker image support: https://railway.app/changelog/2024-03-15-template-composer I was able communicate with them, so they kindly provided a way use pass credentials for private docker registries over public API.

This PR is actually makes this possible using Terraform.

In regards of PR

Note

pksunkara commented 3 months ago

I don't think this is a full implementation because you haven't updated the graphql and logic for reading these props.

I think I need to ask railway people to upgrade my account to Pro so that I can add tests for this and support it.

wertlex commented 3 months ago

I don't think this is a full implementation because you haven't updated the graphql and logic for reading these props.

Unfortunately this is most recent graphql and these properties are write-only. However, it's still a good point. I have to check if there is a good way to communicate to Terraform that these things could never be read back. Probably something like this could be a way to go: https://github.com/hashicorp/terraform-provider-awscc/pull/86 I'll take a look on Monday.

I think I need to ask railway people to upgrade my account to Pro so that I can add tests for this and support it.

Ok, got it!

wertlex commented 3 months ago

I have to check if there is a good way to communicate to Terraform that these things could never be read back. Probably something like this could be a way to go: hashicorp/terraform-provider-awscc#86 I'll take a look on Monday.

I did a quick check, so there is no special actions required to preserve source_image_private_registry_password value, since it is already performed here and never overwritten.