terraform-compliance / cli

a lightweight, security focused, BDD test framework against terraform.
https://terraform-compliance.com
MIT License
1.34k stars 151 forks source link

Dependencies declared in the setup.py are strict and can lead to conflicts when installing #670

Closed looztra closed 1 year ago

looztra commented 1 year ago

Description

Since version 1.3.35, the dependencies declared in the setup.py (and hence used during installation) are all in strict mode:

# v1.3.34
dependencies = [
    'radish-bdd>=0.13.1',
    'gitpython>=3.0.5',
    'netaddr>=0.7.19',
    'colorful>=0.5.4',
    'filetype>=1.0.5',
    'junit-xml>=1.8',
    'lxml>=4.5.0',
    'emoji>=0.5.4',
    'mock>=3.0.5',
    'semver>=2.10.2',
    'IPython==7.16.1',
    'diskcache==5.1.0',
]
# v1.3.35
dependencies = [
    'radish-bdd==0.13.1',
    'gitpython==3.1.20',
    'netaddr==0.8.0',
    'colorful==0.5.4',
    'filetype==1.1.0',
    'junit-xml==1.9',
    'emoji==2.1.0',
    'lxml==4.9.1',
    'semver==2.13.0',
    'IPython==7.16.1',
    'orjson==3.6.0',
    'diskcache==5.4.0'
]

If terraform-compliance is installed in its own venv this is not a problem. I terraform-compliance is installed in a virtual env with other tools/libs, then it is a problem as the strict dependencies can conflict with other tools dependencies.

Could you please get back to a less strict version of the dependencies?

eerkunt commented 1 year ago

good point, fixing this.

looztra commented 1 year ago

Thanks a lot for the fix and for the 1.3.40

https://github.com/terraform-compliance/cli/compare/1.3.39...1.3.40

eerkunt commented 1 year ago

No worries, yep, it is in 1.3.40