search

terraform-coop / terraform-provider-foreman

Terraform provider for Foreman
https://registry.terraform.io/providers/terraform-coop/foreman
Mozilla Public License 2.0
33 stars 31 forks source link

Tests fail in master due to missing handling of "managed" #124

Closed bitkeks closed 1 year ago

bitkeks commented 1 year ago

Currently, some tests on PR branches fail: ResourceData references differ in attribute [managed]. The attributes value differ: [false], [true].

But the issue exists in master (commit bea250423ee28ccc8827125db61ac296327ea851), already:

terraform-provider-foreman (git)-[master] % git diff

terraform-provider-foreman (git)-[master] % go clean -testcache && go clean && go test ./... -covermode=count
?       github.com/terraform-coop/terraform-provider-foreman    [no test files]
?       github.com/terraform-coop/terraform-provider-foreman/cmd/autodoc        [no test files]
--- FAIL: TestCRUDFunction_MockResponse (0.01s)
    [...]
    foreman_api_test.go:685: test case: [{TestCase:{funcName:resourceForemanHostCreate crudFunc:0x998f00 resourceData:0xc00069d500} responseFile:testdata/1.11/hosts/create_response.json returnError:false expectedResourceData:0xc00069d580 compareFunc:0x9c7980}]
    foreman_api_test.go:685: test case: [{TestCase:{funcName:resourceForemanHostRead crudFunc:0x999540 resourceData:0xc00069d600} responseFile:testdata/1.11/hosts/read_response.json returnError:false expectedResourceData:0xc00069d680 compareFunc:0x9c7980}]
    foreman_api_test.go:685: test case: [{TestCase:{funcName:resourceForemanHostUpdate crudFunc:0x999800 resourceData:0xc00069d700} responseFile:testdata/1.11/hosts/update_response.json returnError:false expectedResourceData:0xc00069d780 compareFunc:0x9c7980}]
    foreman_api_test.go:128: ResourceData references differ in attribute [managed]. The attributes value differ: [false], [true]
FAIL
coverage: 44.0% of statements
FAIL    github.com/terraform-coop/terraform-provider-foreman/foreman    0.090s
ok      github.com/terraform-coop/terraform-provider-foreman/foreman/api        0.009s  coverage: 2.6% of statements
FAIL

terraform-provider-foreman (git)-[master] % go clean -testcache && go clean && go test ./... -covermode=count 
?       github.com/terraform-coop/terraform-provider-foreman    [no test files]
?       github.com/terraform-coop/terraform-provider-foreman/cmd/autodoc        [no test files]
ok      github.com/terraform-coop/terraform-provider-foreman/foreman    0.118s  coverage: 51.5% of statements
ok      github.com/terraform-coop/terraform-provider-foreman/foreman/api        0.008s  coverage: 2.6% of statements

terraform-provider-foreman (git)-[master] % go clean -testcache && go clean && go test ./... -covermode=count 
?       github.com/terraform-coop/terraform-provider-foreman    [no test files]
?       github.com/terraform-coop/terraform-provider-foreman/cmd/autodoc        [no test files]
--- FAIL: TestCRUDFunction_MockResponse (0.01s)
[...]

The issue is caused by the revert in bea250423ee28ccc8827125db61ac296327ea851 because it does not set managed anymore.

agriffit79 commented 1 year ago

Fixed in 0.6.0