chore: Update build system

terraform-coop / terraform-provider-foreman

Terraform provider for Foreman

https://registry.terraform.io/providers/terraform-coop/foreman

Mozilla Public License 2.0

33 stars 31 forks source link

chore: Update build system #155

Closed lhw closed 3 months ago

lhw commented 4 months ago

Updating all action versions across the board
Removed the no-op lint step
Added a built-test step
Added darwin/* back to goreleaser (Closes: #154)

evgenkisel commented 4 months ago

@lhw thank you for the PR! Who could help to review and merged it?

evgenkisel commented 3 months ago

any updates?

lhw commented 3 months ago

I'd rather not self-approve. But in general this should be fine now

bitkeks commented 2 months ago

LGTM, thanks @lhw

Last action run for buildtest shows a warning: Warning: Unexpected input(s) 'overwrite', valid inputs are ['name', 'path', 'if-no-files-found', 'retention-days'] That's caused by v3 in actions/upload-artifact@v3 not having the overwrite input: https://github.com/actions/upload-artifact/blob/v3.1.3/action.yml .

But it's available in v4 actions/upload-artifact@v4: https://github.com/actions/upload-artifact/blob/5d5d22a31266ced268874388b861e4b58bb5c2f3/action.yml#L37