terraform-coop / terraform-provider-foreman

Terraform provider for Foreman
https://registry.terraform.io/providers/terraform-coop/foreman
Mozilla Public License 2.0
33 stars 31 forks source link

Improve handling interfaces #33

Closed Fodoj closed 3 years ago

Fodoj commented 3 years ago
  1. Switches interfaces to TypeList for proper updates;
  2. Pulls compute attributes from the host, so that plan is clean (host compute attributes is the only place to fetch interface compute attributes);
  3. Automatically fixes importing of interfaces;
  4. Allows to send interface updates and removal - previously it was just disabled at the very last moment;

Fixes #31

Fodoj commented 3 years ago

@lhw I've removed all ForceNew from interface attributes, because essentially any change in interface forces re-creation of the host - this is not correct, as Foreman allows to modify interfaces just fine, without destroying the host.