This delivers the main goal of issue #60. New build argument allows this flag to be set on existing hosts. Defaults to true, same as if you don't specify in Foreman.
Replaces method which has been deprecated (it's still in schema) and its functionality removed. Method never managed the build flag of existing hosts. Also "build" is more aligned with Foreman terminology.
Continuing to use method argument won't lead to an error, but it won't do anything now. I chose not to leave the existing "if method = build, set build to true" logic during the deprecation period, because it would be too confusing for users. Ie if method = build, but build = false, which wins? Likewise, when "method = interface, but build = true"?
I propose release notes should include:
Breaking Changes:
method argument deprecated and its functionality disabled. New build argument should be used instead
Host build flag will now be set during update of existing hosts, not just at creation.
This delivers the main goal of issue #60. New build argument allows this flag to be set on existing hosts. Defaults to true, same as if you don't specify in Foreman.
Replaces method which has been deprecated (it's still in schema) and its functionality removed. Method never managed the build flag of existing hosts. Also "build" is more aligned with Foreman terminology.
Continuing to use
methodargument won't lead to an error, but it won't do anything now. I chose not to leave the existing "if method = build, set build to true" logic during the deprecation period, because it would be too confusing for users. Ie if method = build, but build = false, which wins? Likewise, when "method = interface, but build = true"?I propose release notes should include:
Breaking Changes:
methodargument deprecated and its functionality disabled. Newbuildargument should be used instead