search

terraform-google-modules / cloud-foundation-training

https://registry.terraform.io/modules/terraform-google-modules/cloud-foundation-training/google
Apache License 2.0
96 stars 90 forks source link

Module 02-IAM, section 1 wording is confusing #16

Closed deathstarjanitor closed 4 years ago

deathstarjanitor commented 4 years ago

Wording in section 1 suggests to create a binding for a 'user' and 'group' but I believe the intent of this portion is to add a set of roles to the service account created in earlier portions.

Perhaps this could be reworded to be more clear.

deathstarjanitor commented 4 years ago

Also worth noting that if you run this module against your service account, the final step of terraform destroy will remove necessary permissions from the Service Account

zefdelgadillo commented 4 years ago

The intent is to create bindings for another user to demonstrate IAM bindings using CFT - not necessarily to set permissions on the service account used for your lab (which happen via setup). Will update the wording to make this more clear.