terraform-google-modules / cloud-foundation-training

https://registry.terraform.io/modules/terraform-google-modules/cloud-foundation-training/google
Apache License 2.0
98 stars 91 forks source link

Downloading the service account key in 00-Setup is redundant #84

Closed derailed-dash closed 6 months ago

derailed-dash commented 6 months ago

In 00-Setup, section 4 describes downloading a service account key for Terraform. However, this is unnecessary since in Section 2, we're using gcloud auth application-default login, such that Terraform can use ADC.

(It is presumably best practice to use ADC and not use the service account key.)

I have tested the 01-Getting-Started phase without downloading the service account key, and it works fine.