Closed aston-github closed 1 month ago
Here is the summary of changes.
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run
label or use the checkbox below:
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge
label. Good luck human!
-- conventional-commit-lint bot https://conventionalcommits.org/
/gcbrun
/gcbrun
VCR test was failing due to a panic during type assertion in expandNodeConfig. I submitted changes in magic-modules to gracefully handle the config type assertion in https://github.com/hashicorp/terraform-provider-google/pull/18323 . I added a near identical test case to the acceptance test in magic-modules, which passed. Machine type is the only difference.
Unclear why the test is failing, seems like ${_BASE_BRANCH}
isn't being populated for some reason?
@aston-github - maybe try amending your last commit? (or similar)
/gcbrun
OK - The CI test appears to be running correctly after the new commit.
/gcbrun
/gcbrun
Description
Fixes #
Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.
Checklist
Readiness
Style
Testing
[x] I have performed tests described in the Contributing guide:
terraform apply
terraform fmt
checkIntended location
[x] Yes, this sample will be (or already is) included on cloud.google.com Location(s): https://cloud.google.com/kubernetes-engine/docs/how-to/data-container-image-preloading
[ ] No, this sample won't be included on cloud.google.com Reason:
API enablement
Review