terraform-google-modules / terraform-docs-samples

Terraform samples intended for inclusion in cloud.google.com
Apache License 2.0
282 stars 207 forks source link

feat(GKE): Add secondary boot disk sample for preloaded data #684

Closed aston-github closed 1 month ago

aston-github commented 1 month ago

Description

Fixes #

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

Style

Testing

Intended location

API enablement

Review

snippet-bot[bot] commented 1 month ago

Here is the summary of changes.

You are about to add 3 region tags. - [gke/standard/zonal/secondary-boot-disk/main.tf:17](https://github.com/aston-github/terraform-docs-samples/blob/ab6ffea3ba22b885c7a168aaf6c08f2c94ec4785/gke/standard/zonal/secondary-boot-disk/main.tf#L17), tag `gke_standard_zonal_secondary_boot_disk_cluster` - [gke/standard/zonal/secondary-boot-disk/main.tf:30](https://github.com/aston-github/terraform-docs-samples/blob/ab6ffea3ba22b885c7a168aaf6c08f2c94ec4785/gke/standard/zonal/secondary-boot-disk/main.tf#L30), tag `gke_standard_zonal_secondary_boot_disk_container` - [gke/standard/zonal/secondary-boot-disk/main.tf:51](https://github.com/aston-github/terraform-docs-samples/blob/ab6ffea3ba22b885c7a168aaf6c08f2c94ec4785/gke/standard/zonal/secondary-boot-disk/main.tf#L51), tag `gke_standard_zonal_secondary_boot_disk_data`
You are about to delete 1 region tag. - [gke/standard/zonal/secondary-boot-disk/main.tf:17](https://github.com/terraform-google-modules/terraform-docs-samples/blob/614bc384dd772f5d8e4648e488dadf1d742120f2/gke/standard/zonal/secondary-boot-disk/main.tf#L17), tag `gke_standard_zonal_secondary_boot_disk`

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

conventional-commit-lint-gcf[bot] commented 1 month ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

aston-github commented 1 month ago

/gcbrun

apeabody commented 1 month ago

/gcbrun

aston-github commented 1 month ago

VCR test was failing due to a panic during type assertion in expandNodeConfig. I submitted changes in magic-modules to gracefully handle the config type assertion in https://github.com/hashicorp/terraform-provider-google/pull/18323 . I added a near identical test case to the acceptance test in magic-modules, which passed. Machine type is the only difference.

apeabody commented 1 month ago

Unclear why the test is failing, seems like ${_BASE_BRANCH} isn't being populated for some reason?

@aston-github - maybe try amending your last commit? (or similar)

apeabody commented 1 month ago

/gcbrun

apeabody commented 1 month ago

OK - The CI test appears to be running correctly after the new commit.

apeabody commented 1 month ago

/gcbrun

apeabody commented 1 month ago

/gcbrun