terraform-google-modules / terraform-docs-samples

Terraform samples intended for inclusion in cloud.google.com
Apache License 2.0
299 stars 215 forks source link

feat(bigquery): Add example for creating a reservation assignment #695

Closed ccarpentiere closed 3 months ago

ccarpentiere commented 3 months ago

Description

Fixes b/269302678

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

Style

Testing

Intended location

API enablement

Review

snippet-bot[bot] commented 3 months ago

Here is the summary of changes.

You are about to add 1 region tag. - [bigquery/bigquery_create_reservation_assignment/main.tf:17](https://github.com/ccarpentiere/terraform-docs-samples/blob/f134d5f98af420448adb27f9efd2264ae3d850bf/bigquery/bigquery_create_reservation_assignment/main.tf#L17), tag `bigquery_create_reservation_assignment`

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

ccarpentiere commented 3 months ago

I can merge the new example into /bigquery_create_reservation/main.tf if you prefer. It will still need a test.yaml file I think. The sample refers to an example project to apply to the reservation assignment, which causes the terraform-docs-samples-int-trigger check to fail when it tries to create a reservation in that project.