terraform-google-modules / terraform-docs-samples

Terraform samples intended for inclusion in cloud.google.com
Apache License 2.0
282 stars 207 forks source link

docs: Add Managed Kafka terraform samples for Clusters and Topics #696

Closed jessdejong closed 4 weeks ago

jessdejong commented 1 month ago

Description

Fixes https://b.corp.google.com/issues/343411931

Checklist

Readiness

Style

Testing

Intended location

API enablement

Review

snippet-bot[bot] commented 1 month ago

Here is the summary of changes.

You are about to add 4 region tags. - [managedkafka/managedkafka_create_cluster/main.tf:17](https://github.com/jessdejong/terraform-docs-samples/blob/ad53b5111fcac0ed8ac01a4cb1ea7e3441da98c5/managedkafka/managedkafka_create_cluster/main.tf#L17), tag `managedkafka_create_cluster_parent` - [managedkafka/managedkafka_create_cluster/main.tf:18](https://github.com/jessdejong/terraform-docs-samples/blob/ad53b5111fcac0ed8ac01a4cb1ea7e3441da98c5/managedkafka/managedkafka_create_cluster/main.tf#L18), tag `managedkafka_create_cluster` - [managedkafka/managedkafka_create_topic/main.tf:17](https://github.com/jessdejong/terraform-docs-samples/blob/ad53b5111fcac0ed8ac01a4cb1ea7e3441da98c5/managedkafka/managedkafka_create_topic/main.tf#L17), tag `managedkafka_create_topic_parent` - [managedkafka/managedkafka_create_topic/main.tf:35](https://github.com/jessdejong/terraform-docs-samples/blob/ad53b5111fcac0ed8ac01a4cb1ea7e3441da98c5/managedkafka/managedkafka_create_topic/main.tf#L35), tag `managedkafka_create_topic`

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

conventional-commit-lint-gcf[bot] commented 1 month ago

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

jessdejong commented 1 month ago

This PR is starting from scratch from https://github.com/terraform-google-modules/terraform-docs-samples/pull/687 because the original PR got too messy.

jessdejong commented 1 month ago

@msampathkumar should be the reviewer (they were reviewing the previous PR)

glasnt commented 1 month ago

Both executions of this PR failed the integration tests with the same error after just shy of 1 hour:

Error waiting for Creating Cluster: Error code 13, message: an internal error has occurred

The latest CI run from the previous PR had a successful creation of the instance in under 30 minutes.

Re-running tests to see if this is a temporary issue.

/gcbrun

jessdejong commented 1 month ago

Yeah, there was a production issue but that should be resolved now. Thanks for re-running.

msampathkumar commented 1 month ago

Hi @jessdejong shared you a PR suggestion.

@glasnt is one of our awesome leads for this repo. Along with @glasnt, we leads share a cross products interest to support PR like this. In this PR, you are adding codeowner - managedkafka-dev-team. So going forward, this managedkafka-dev-team members can be your first reviewers for this product samples.

I see you are doing good work already but let me say it again. Be familiarise yourself with https://googlecloudplatform.github.io/samples-style-guide/ and if you need support, do reach out chat group or to glasnt or myself.

You are doing great! 👍

msampathkumar commented 1 month ago

/gcbrun

glasnt commented 1 month ago

/gcbrun

glasnt commented 1 month ago

Lint diskspace errors reported in https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/issues/2427

jessdejong commented 4 weeks ago

Thanks for your help! Please LMK if there is anything else. It looks like the lint errors seem unrelated -- are we able to submit now?

(also pls see my comment about making the subnet "default", unfortunately we are not able to do that)

glasnt commented 4 weeks ago

/gcbrun