Closed jessdejong closed 4 weeks ago
Here is the summary of changes.
This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run
label or use the checkbox below:
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge
label. Good luck human!
-- conventional-commit-lint bot https://conventionalcommits.org/
This PR is starting from scratch from https://github.com/terraform-google-modules/terraform-docs-samples/pull/687 because the original PR got too messy.
@msampathkumar should be the reviewer (they were reviewing the previous PR)
Both executions of this PR failed the integration tests with the same error after just shy of 1 hour:
Error waiting for Creating Cluster: Error code 13, message: an internal error has occurred
The latest CI run from the previous PR had a successful creation of the instance in under 30 minutes.
Re-running tests to see if this is a temporary issue.
/gcbrun
Yeah, there was a production issue but that should be resolved now. Thanks for re-running.
Hi @jessdejong shared you a PR suggestion.
@glasnt is one of our awesome leads for this repo. Along with @glasnt, we leads share a cross products interest to support PR like this. In this PR, you are adding codeowner - managedkafka-dev-team
. So going forward, this managedkafka-dev-team
members can be your first reviewers for this product samples.
I see you are doing good work already but let me say it again. Be familiarise yourself with https://googlecloudplatform.github.io/samples-style-guide/ and if you need support, do reach out chat group or to glasnt or myself.
You are doing great! 👍
/gcbrun
/gcbrun
Lint diskspace errors reported in https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/issues/2427
Thanks for your help! Please LMK if there is anything else. It looks like the lint errors seem unrelated -- are we able to submit now?
(also pls see my comment about making the subnet "default", unfortunately we are not able to do that)
/gcbrun
Description
Fixes https://b.corp.google.com/issues/343411931
Checklist
Readiness
Style
Testing
[x] I have performed tests described in the Contributing guide:
terraform apply
terraform fmt
checkIntended location
[x] Yes, this sample will be (or already is) included on cloud.google.com Location(s): https://cloud.google.com/managed-kafka/docs
[ ] No, this sample won't be included on cloud.google.com Reason:
API enablement
Review