terraform-google-modules / terraform-docs-samples

Terraform samples intended for inclusion in cloud.google.com
Apache License 2.0
299 stars 215 forks source link

feat(bigquery): Add example for creating a reservation assignment #698

Closed ccarpentiere closed 2 months ago

ccarpentiere commented 3 months ago

Description

Fixes #269302678

Note: If you are not associated with Google, open an issue for discussion before submitting a pull request.

Checklist

Readiness

Style

Testing

Intended location

API enablement

Review

snippet-bot[bot] commented 3 months ago

Here is the summary of changes.

You are about to add 1 region tag. - [bigquery/bigquery_create_reservation/main.tf:17](https://github.com/ccarpentiere/terraform-docs-samples/blob/37859582a5e6125c5d36813cad29d94320b456ab/bigquery/bigquery_create_reservation/main.tf#L17), tag `bigquery_create_reservation_assignment`

This comment is generated by snippet-bot. If you find problems with this result, please file an issue at: https://github.com/googleapis/repo-automation-bots/issues. To update this comment, add snippet-bot:force-run label or use the checkbox below:

ccarpentiere commented 3 months ago

Can I merge this since I have one approval, or do I need to wait for review from terraform-google-modules/terraform-samples-reviewers?

wj-chen commented 3 months ago

Can I merge this since I have one approval, or do I need to wait for review from terraform-google-modules/terraform-samples-reviewers?

Would suggest to get an approval from the other group since bigquery-terraform-swe is primarily to check the validity of the content of the examples and not so much on the style guide and other repo-specific guidelines.