Closed ferrarimarco closed 2 weeks ago
/cc @nityaravi
@ferrarimarco @glasnt For samples it would be better to ask user to modify inline rather than exposing a var. https://googlecloudplatform.github.io/samples-style-guide/#no-global-variables
Good point, @bharathkkb. I was working with the description from the PR as to why this was being included.
@ferrarimarco If you could share your usage with me, including your intended tutorial updates, we can adjust to adhere to the styleguide (glasnt@)
Description
Use a variable to set the force_destroy attribute of the Cloud Storage bucket to store the Terraform state. This is helpful to simplify the related tutorial because we can ask users to adjust the value of the variable, instead of asking them to modify the source code.
Checklist
Readiness
Style
Testing
[x] I have performed tests described in the Contributing guide:
terraform apply
terraform fmt
checkIntended location
[x] Yes, this sample will be (or already is) included on cloud.google.com Location(s):
[ ] No, this sample won't be included on cloud.google.com Reason:
API enablement
Review