terraform-google-modules / terraform-docs-samples

Terraform samples intended for inclusion in cloud.google.com
Apache License 2.0
282 stars 207 forks source link

feat: make force_destroy configurable #703

Closed ferrarimarco closed 2 weeks ago

ferrarimarco commented 3 weeks ago

Description

Use a variable to set the force_destroy attribute of the Cloud Storage bucket to store the Terraform state. This is helpful to simplify the related tutorial because we can ask users to adjust the value of the variable, instead of asking them to modify the source code.

Checklist

Readiness

Style

Testing

Intended location

API enablement

Review

ferrarimarco commented 3 weeks ago

/cc @nityaravi

bharathkkb commented 2 weeks ago

@ferrarimarco @glasnt For samples it would be better to ask user to modify inline rather than exposing a var. https://googlecloudplatform.github.io/samples-style-guide/#no-global-variables

glasnt commented 2 weeks ago

Good point, @bharathkkb. I was working with the description from the PR as to why this was being included.

@ferrarimarco If you could share your usage with me, including your intended tutorial updates, we can adjust to adhere to the styleguide (glasnt@)