terraform-google-modules / terraform-example-foundation

Shows how the CFT modules can be composed to build a secure cloud foundation
https://cloud.google.com/architecture/security-foundations
Apache License 2.0
1.21k stars 708 forks source link

terraform plan truncated in github actions comments #1130

Closed nbugden closed 3 months ago

nbugden commented 6 months ago

TL;DR

The terraform plan generated in GitHub Actions is often truncated when the comment is posted to a PR. This is because the comment is posting the stdout for all environments not just the plan generated by terraform.

Expected behavior

Log the terraform plan as a separate text file for each environment and then use those files to create 1 comment per environment on the PR.

Observed behavior

One comment is created on the PR for all environments. This comment includes unnecessary logs related to the init which uses characters that could have been reserved for the plan.

Terraform Configuration

n/a

Terraform Version

n/a

Additional information

No response

github-actions[bot] commented 4 months ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

nbugden commented 4 months ago

Still open

eeaton commented 3 months ago

Fixed in #1129