Closed nbugden closed 3 months ago
@rjerrems @eeaton @gtsorbo can one of you folks take a look. PR needs /gcbrun
and an approving review.
@rjerrems @eeaton @gtsorbo can one of you folks take a look. PR needs
/gcbrun
and an approving review.
Nudge, can I get a review. If there is something else required before review, please let me know.
/gcbrun
Thanks for the submission!
/gcbrun
Thanks for the submission!
Thanks @eeaton looks like it needs /gcbrun again. I just pulled in the latest changes from master.
@eeaton checks have passed. Ready to be merge, but I'm not authorized.
/gcbrun
Looks like this time both cloud build checks failed. I can't see the failures. I also had to pull in the latest changes. Can you help me with the error so I can address any changes needed in the PR?
/gcbrun
@nbugden The CI tests that do a complete build of the foundation have been failing with a high frequency of flaky errors that don't seem to have anything to do with the proposed changes. (I'm getting stuck on several other PR with small tweaks as well). In this case, the errors do seem to be a flaky failure and not any issues with your PR.
A few PR have managed to pass for the small %age of times that the CI runs without errors, so it's worth trying to re-run a few times, but I'm also in the process of trying to improve the reliability of tests.
/gcbrun
Needs /gcbrun again
Checks are still failing... needs to be rerun
/gcbrun
/gcbrun
Check have passed... can someone merge?
@eeaton my branch is behind the renovate bot changes... auto-merge is not being triggered. If I pull in the latest it will clear the auto-merge and force the pipelines to run again.
/gcbrun
Remove unused tfvars that were removed in this commit: https://github.com/terraform-google-modules/terraform-example-foundation/commit/f57a47c2e36e9924a3232983385e741fd05ee2f3#diff-772cebf2058d9fd66a2fd923eb13802b5a561daff7c66d1950d19675a3aa93f1