terraform-google-modules / terraform-example-foundation

Shows how the CFT modules can be composed to build a secure cloud foundation
https://cloud.google.com/architecture/security-foundations
Apache License 2.0
1.22k stars 714 forks source link

chore(resourcehierarchy): disambiguate prj-c-logging and prj-c-billing-logs #1197

Closed eeaton closed 4 months ago

eeaton commented 5 months ago

This PR changes one project name and moves one resource to another project for logical grouping where the implementation differs from the original design.

Change 1: improve unclear project names

Change 2: location of billing account log sink

In v4 changes, we added a billing account log sink to collect admin activity logs related to changes on the Billing Account. This should be grouped into the same project as other admin activity logs from across the org, but was accidentally deployed to the project for cost data exports, so I've moved the sink destination to prj-c-logging

eeaton commented 4 months ago

@sleighton2022 can I get a review on this one? non-functional changes