Closed fmichaelobrien closed 1 month ago
/gcbrun
either of #1233 or #1230
can go in - they are the same fix
Daniel, myself and the team - really appreciate the speed that this PR was reviewed - thank you For gcbrun - Looking into the build issues - looks quota related - will retry
/gcbrun
@fmichaelobrien could you please update the PR with the base branch?
Will do, eta 30 min...
/gcbrun
/gcbrun
/gcbrun
@fmichaelobrien we've had a few concurrent PRs that have put this one out-of-date with base branch, but if you sync it I'll re-trigger the CI tests and merge now. (will hold off on a few other PR until this one passes)
Syncing now - eta 10 min
sync complete - no merge conflicts on https://github.com/CloudLandingZone/terraform-example-foundation/tree/gh1229-fix-symlinks
/gcbrun
see testing on #1229
3-networks-hub-and-spoke
https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/3-networks-hub-and-spoke/envs/nonproduction/access_context.auto.tfvars
there is a 2nd symlink regression in the same directory in https://github.com/terraform-google-modules/terraform-example-foundation/blob/master/3-networks-hub-and-spoke/envs/nonproduction/common.auto.tfvars
I'll raise an issue shortly with the fix after I test a full upstream sync of the TEF.