chore(CI): remove business_unit_2 to reduce CI scope

terraform-google-modules / terraform-example-foundation

Shows how the CFT modules can be composed to build a secure cloud foundation

https://cloud.google.com/architecture/security-foundations

Apache License 2.0

1.18k stars 701 forks source link

chore(CI): remove business_unit_2 to reduce CI scope #1241

Closed eeaton closed 1 month ago

eeaton commented 1 month ago

Deleted subfolder for business_unit_2 under under step 4-projects, with updated directions in Readme for users to optionally recreate the this folder and automatically replace strings that change between bu1 and bu2.

This should help improve the flakiness of CI tests where a small chance of flaky error becomes cumulatively higher when creating a large number of projects (this reduces the test scope by 15 projects).

eeaton commented 1 month ago

Thanks for the feedback @daniel-cit . I removed those instances of business_unit_2 in the .go tests, and found a few similar places in the helper script to remove. I decided that leaving it in the README files is ok to illustrate what the complete structure looks like if someone does take the optional steps to duplicate bu2 folders.