search

terraform-google-modules / terraform-google-bigquery

Creates opinionated BigQuery datasets and tables
https://registry.terraform.io/modules/terraform-google-modules/bigquery/google
Apache License 2.0
199 stars 169 forks source link

feature(TPG>=5.39)!: add resource_tags #354

Closed lord-skinner closed 1 week ago

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

lord-skinner commented 1 month ago

Closes #351

lord-skinner commented 1 month ago

@davenportjw @shanecglass The CI error failing is Needs /gcbrun from a collaborator, but I'm not sure how to proceed with this information.

Can you let us know how to proceed?

cc:@rohilla-anuj

bharathkkb commented 2 weeks ago

/gcbrun

rohilla-anuj commented 2 weeks ago

@bharathkkb Thanks for looking into the PR. Made the change as per your suggestion.

rohilla-anuj commented 1 week ago

Fixed the Lint error. @bharathkkb can you approve /gcbrun again.

apeabody commented 1 week ago

/gcbrun

apeabody commented 1 week ago

/gcbrun

apeabody commented 1 week ago

/gcbrun

apeabody commented 1 week ago

Thanks @lord-skinner - Can you please rebase this change (its not enabled for maintainers), otherwise it LGTM.

apeabody commented 1 week ago

/gcbrun

apeabody commented 1 week ago

Thanks @lord-skinner - Can you please rebase this change (its not enabled for maintainers), otherwise it LGTM.

Thanks for the contribution @lord-skinner!