terraform-google-modules / terraform-google-bootstrap

Bootstraps Terraform usage and related CI/CD in a new Google Cloud organization
https://registry.terraform.io/modules/terraform-google-modules/bootstrap/google
Apache License 2.0
212 stars 145 forks source link

fix: Include cloudkms.googleapis.com API to activate when encrypt_gcs_bucket_tfstate set to true #302

Closed lpezet closed 1 month ago

lpezet commented 2 months ago

… set to true.

lpezet commented 2 months ago

I tried running make docker_test_lint and make docker_test_prepare (before my changes and even after my changes) but I got some errors (same errors) both times. The make docker_test_lint gave me (again, using pristine version from main):

...
terraform_validate ./test/integration/im_cloudbuild_workspace_github/files
Success! The configuration is valid.

terraform_validate ./test/integration/im_cloudbuild_workspace_gitlab/files
Success! The configuration is valid.

terraform_validate ./test/setup
Success! The configuration is valid.

ENABLE_BPMETADATA not set to 1. Skipping metadata validation.
Error: The following tests have failed: check_whitespace
make: *** [Makefile:74: docker_test_lint] Error 1

And make docker_test_prepare gave me:

...
module.project.module.project-factory.module.project_services.google_project_service.project_services["cloudresourcemanager.googleapis.com"]: Creation complete after 1m0s [id=ci-bootstrap-6374/cloudresourcemanager.googleapis.com]
module.project.module.project-factory.module.project_services.google_project_service.project_services["secretmanager.googleapis.com"]: Still creating... [1m10s elapsed]
module.project.module.project-factory.module.project_services.google_project_service.project_services["secretmanager.googleapis.com"]: Creation complete after 1m12s [id=ci-bootstrap-6374/secretmanager.googleapis.com]
╷
│ Error: Request `Enable Project Service "sourcerepo.googleapis.com" for project "ci-bootstrap-6374"` returned error: Batch request and retried single request "Enable Project Service \"sourcerepo.googleapis.com\" for project \"ci-bootstrap-6374\"" both failed. Final error: failed to enable services: failed on request preconditions: googleapi: Error 403: Permission denied to enable service [sourcerepo.googleapis.com]
│ Help Token: ARZIt86OfxpUmldE3sg5_iLxJEi3g6JgEuWBCIbM4I-GEassILjROvY2vbKXjjbACWHeL5BzZFnDhFtYP5jglA6_aGnQneZv52GXGQ4Bv6RXquTN
│ Details:
│ [
│   {
│     "@type": "type.googleapis.com/google.rpc.PreconditionFailure",
│     "violations": [
│       {
│         "subject": "?error_code=110002\u0026service=servicemanagement.googleapis.com\u0026permission=servicemanagement.services.bind\u0026resource=ci-bootstrap-6374",
│         "type": "googleapis.com"
│       }
│     ]
│   },
│   {
│     "@type": "type.googleapis.com/google.rpc.ErrorInfo",
│     "domain": "serviceusage.googleapis.com",
│     "metadata": {
│       "permission": "servicemanagement.services.bind",
│       "resource": "ci-bootstrap-6374",
│       "service": "servicemanagement.googleapis.com"
│     },
│     "reason": "AUTH_PERMISSION_DENIED"
│   }
│ ]
│ , forbidden
│ 
│   with module.project.module.project-factory.module.project_services.google_project_service.project_services["sourcerepo.googleapis.com"],
│   on .terraform/modules/project/modules/project_services/main.tf line 31, in resource "google_project_service" "project_services":
│   31: resource "google_project_service" "project_services" {
│ 
╵
make: *** [Makefile:37: docker_test_prepare] Error 1
apeabody commented 1 month ago

/gcbrun