terraform-google-modules / terraform-google-bootstrap

Bootstraps Terraform usage and related CI/CD in a new Google Cloud organization
https://registry.terraform.io/modules/terraform-google-modules/bootstrap/google
Apache License 2.0
212 stars 145 forks source link

feat(module): add cloudbuild connection module #312

Closed caetano-colin closed 1 month ago

caetano-colin commented 1 month ago

This PR will add the module cloudbuild_repo_connection.

This module is designed to create and manage secret versions, as well as configure the necessary permissions for cloud build service agent when utilizing Cloud Build repositories (2nd generation).

Additionally, it will establish the corresponding Cloud Build repositories based on the cloudbuild_repos variable, where users can specify the repository names and URLs from their version control systems.

Users will provide the required secrets through the credential_config variable, indicating their chosen Git provider. Currently, the module supports both GitHub and GitLab.

caetano-colin commented 1 month ago

/gcbrun

daniel-cit commented 1 month ago

/gcbrun

daniel-cit commented 1 month ago

/gcbrun

apeabody commented 1 month ago

/gcbrun

daniel-cit commented 1 month ago

/gcbrun

daniel-cit commented 1 month ago

/gcbrun

daniel-cit commented 1 month ago

/gcbrun

daniel-cit commented 1 month ago

/gcbrun

daniel-cit commented 1 month ago

/gcbrun

daniel-cit commented 1 month ago

/gcbrun

daniel-cit commented 1 month ago

/gcbrun

caetano-colin commented 1 month ago

@apeabody thank you for the review! I implemented the requested changes. Regarding the module registry version I put:

version = "~> 9.0"

I'm assuming that would be the module version, If that is not correct please let me know.

apeabody commented 1 month ago

@apeabody thank you for the review! I implemented the requested changes. Regarding the module registry version I put:

version = "~> 9.0"

I'm assuming that would be the module version, If that is not correct please let me know.

Yeah, that should be fine for now. Thanks!

apeabody commented 1 month ago

/gcbrun

apeabody commented 1 month ago

@caetano-colin - The last INT test didn't complete before timeout, might want to bump slightly: https://github.com/terraform-google-modules/terraform-google-bootstrap/blob/master/build/int.cloudbuild.yaml#L15

apeabody commented 1 month ago

@gtsorbo do you want to review before merging?

caetano-colin commented 1 month ago

@caetano-colin - The last INT test didn't complete before timeout, might want to bump slightly: https://github.com/terraform-google-modules/terraform-google-bootstrap/blob/master/build/int.cloudbuild.yaml#L15

Created a commit that increases the timeout in 10minutes

daniel-cit commented 1 month ago

/gcbrun