search

terraform-google-modules / terraform-google-cloud-datastore

Manages Datastore
https://registry.terraform.io/modules/terraform-google-modules/cloud-datastore/google
Apache License 2.0
22 stars 33 forks source link

Add test coverage for Terraform outputs #5

Closed adrienthebo closed 5 years ago

adrienthebo commented 5 years ago

This pull request adds the terraform_outputs InSpec profile and adds test coverage to the module outputs.

This pull request also fixes up a small refactoring error in the InSpec tests.

morgante commented 5 years ago

@adrienthebo Attempting to run this inside Docker (using make docker_run), I get the following error on kitchen verify:

>>>>>> ------Exception-------
>>>>>> Class: Kitchen::ActionFailed
>>>>>> Message: 1 actions failed.
>>>>>>     Failed to complete #verify action: [Error running 'git ls-remote "https://github.com/lagrange-automation/inspec-terraform" "master*"': fatal: Not a git repository: ../../.git/modules/modules/datastore
] on default-local
>>>>>> ----------------------
>>>>>> Please see .kitchen/logs/kitchen.log for more details
>>>>>> Also try running `kitchen diagnose --all` for configuration

This looks like it might have been a side-effect of running inside a submodule directory, so not a blocker.