search

terraform-google-modules / terraform-google-cloud-nat

Creates and configures Cloud NAT
https://registry.terraform.io/modules/terraform-google-modules/cloud-nat/google
Apache License 2.0
80 stars 68 forks source link

fix!: Set endpoint-independent-mapping default to false #113

Closed sclausson closed 10 months ago

sclausson commented 1 year ago

Fix for issue https://github.com/terraform-google-modules/terraform-google-cloud-nat/issues/112

apeabody commented 1 year ago

/gcbrun

imrannayer commented 1 year ago

@sclausson @apeabody this will be breaking change. Since we already have 4.0 lined up this can go in there.

imrannayer commented 1 year ago

/gcbrun

imrannayer commented 1 year ago

@sclausson Integration test is failing for enableEndpointIndependentMapping value. Can you plz change this to false in: 1) https://github.com/terraform-google-modules/terraform-google-cloud-nat/blob/master/test/integration/advanced/testdata/TestAdvanced.json 2) https://github.com/terraform-google-modules/terraform-google-cloud-nat/blob/master/test/integration/basic/testdata/TestBasic.json 3) https://github.com/terraform-google-modules/terraform-google-cloud-nat/blob/master/test/integration/subnetworks/testdata/TestSubnetworks.json

imrannayer commented 1 year ago

@sclausson r u still working on this PR?

github-actions[bot] commented 1 year ago

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

github-actions[bot] commented 11 months ago

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

apeabody commented 10 months ago

Thanks @sclausson - Included with test fixture updates in #129