search

terraform-google-modules / terraform-google-cloud-nat

Creates and configures Cloud NAT
https://registry.terraform.io/modules/terraform-google-modules/cloud-nat/google
Apache License 2.0
80 stars 68 forks source link

feat: add support for max ports per vm #124

Closed nikhilmakhijani closed 1 year ago

nikhilmakhijani commented 1 year ago

Issue #123 : Adding support for max ports per vm

nikhilmakhijani commented 1 year ago

@apeabody / @g-awmalik could you please review

nikhilmakhijani commented 1 year ago

/gcbrun

apeabody commented 1 year ago

/gcbrun

imrannayer commented 1 year ago

@nikhilmakhijani enable_dynamic_port_allocation needs to be true to set max_ports_per_vm. Can you plz ignore this value in terraform code if enable_dynamic_port_allocation is set to false.

  max_ports_per_vm  = var.enable_dynamic_port_allocation ? var.max_ports_per_vm : null

Also add it to variable max_ports_per_vm description "this will be ignored if enable_dynamic_port_allocation is set to false"

nikhilmakhijani commented 1 year ago

@nikhilmakhijani enable_dynamic_port_allocation needs to be true to set max_ports_per_vm. Can you plz ignore this value in terraform code if enable_dynamic_port_allocation is set to false.

  max_ports_per_vm  = var.enable_dynamic_port_allocation ? var.max_ports_per_vm : null

Also add it to variable max_ports_per_vm description "this will be ignored if enable_dynamic_port_allocation is set to false"

Makes sense! I have added the changes suggested by you.

imrannayer commented 1 year ago

/gcbrun

imrannayer commented 1 year ago

/gcbrun