search

terraform-google-modules / terraform-google-cloud-nat

Creates and configures Cloud NAT
https://registry.terraform.io/modules/terraform-google-modules/cloud-nat/google
Apache License 2.0
80 stars 68 forks source link

fix(enable_endpoint_independent_mapping=false)!: upgraded versions.tf to include minor bumps from tpg v5 #129

Closed g-awmalik closed 1 year ago

g-awmalik commented 1 year ago

Fixes: #112, #113

For details see upgrading_to_v5.0.md

imrannayer commented 1 year ago

@g-awmalik there is a behavior change in 5.x. Default value of enable_endpoint_independent_mapping is now set to FALSE. It was TRUE pre 5.X. Should we make it a breaking change?

imrannayer commented 1 year ago

@g-awmalik for some reason gcloud command is returning an extra information autoNetworkTier. We may need to add it in test data

apeabody commented 1 year ago

@g-awmalik there is a behavior change in 5.x. Default value of enable_endpoint_independent_mapping is now set to FALSE. It was TRUE pre 5.X. Should we make it a breaking change?

Alternatively we could switch the variable from null to true which maintain the previous behavior and so avoid a breaking change on requiring tpg v5, however that would differ from the provider new default: https://registry.terraform.io/providers/hashicorp/google/5.0.0/docs/guides/version_5_upgrade#enable_endpoint_independent_mapping-now-defaults-to-apis-default-value-which-is-false

apeabody commented 1 year ago

@g-awmalik for some reason gcloud command is returning an extra information autoNetworkTier. We may need to add it in test data

fixed and committed to repo

apeabody commented 1 year ago

@g-awmalik there is a behavior change in 5.x. Default value of enable_endpoint_independent_mapping is now set to FALSE. It was TRUE pre 5.X. Should we make it a breaking change?

Alternatively we could switch the variable from null to true which maintain the previous behavior and so avoid a breaking change on requiring tpg v5, however that would differ from the provider new default: https://registry.terraform.io/providers/hashicorp/google/5.0.0/docs/guides/version_5_upgrade#enable_endpoint_independent_mapping-now-defaults-to-apis-default-value-which-is-false

Looks like the preferable option is, in-line with tpg v5 default, is false. So we'll make this a breaking change.