terraform-google-modules / terraform-google-cloud-nat

Creates and configures Cloud NAT
https://registry.terraform.io/modules/terraform-google-modules/cloud-nat/google
Apache License 2.0
80 stars 68 forks source link

feat: `bgp` block can now be optional #152

Closed tanguynicolas closed 4 months ago

tanguynicolas commented 5 months ago

I have a customer who has not defined (from console) the bgp block. When I use the module, it creates a change. I don't currently have the option of setting the ASN to null to avoid creating the block.

The purpose of this PR is to support my use case. To reflect a little more the google_compute_router_nat resource which doesn't require the bgp block.

tanguynicolas commented 5 months ago

Sorry, bad commit message. It's a feature not a chore.
If you're ok with the changes I've made, let me know and I'll re-create the commit with the message feat: bgp block can now be optional

imrannayer commented 5 months ago

@tanguynicolas thx for the PR. can you plz fix lint issues. See contributing guide

imrannayer commented 4 months ago

/gcbrun

imrannayer commented 4 months ago

/gcbrun