terraform-google-modules / terraform-google-cloud-nat

Creates and configures Cloud NAT
https://registry.terraform.io/modules/terraform-google-modules/cloud-nat/google
Apache License 2.0
80 stars 68 forks source link

feat: add drain_nat_ips support #162

Closed LeandroFPeixoto closed 3 weeks ago

LeandroFPeixoto commented 1 month ago

In this PR I'm including support for the field drain_nat_ips.

This functionality is very useful, when turned on, Cloud NAT IP address will be in Drain mode, meaning that the Cloud NAT IP does not accept any new connections.

Ref: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/compute_router_nat#drain_nat_ips

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

LeandroFPeixoto commented 1 month ago

Linked issue https://github.com/terraform-google-modules/terraform-google-cloud-nat/issues/163

imrannayer commented 1 month ago

@LeandroFPeixoto thx for the PR. Can you plz remove VsCode files?

LeandroFPeixoto commented 1 month ago

@LeandroFPeixoto thx for the PR. Can you plz remove VsCode files?

@imrannayer, done!

imrannayer commented 1 month ago

/gcbrun