search

terraform-google-modules / terraform-google-cloud-nat

Creates and configures Cloud NAT
https://registry.terraform.io/modules/terraform-google-modules/cloud-nat/google
Apache License 2.0
81 stars 68 forks source link

enable_endpoint_independent_mapping attribute not supported by module #43

Closed cgsquid closed 3 years ago

cgsquid commented 3 years ago

The enable_endpoint_independent_mapping argument is not supported in this module, but supported by the underlying google_compute_router_nat resource. It would be helpful to be able to pass this argument using cloud-nat module.

mark-00 commented 3 years ago

the field is recently added to the google provider in release 3.52.0

billyfoss commented 3 years ago

Yes, this will require an update in the required provider version. It also requires a small fix to pass the extra parameter through the module.
I'm not sure if the parameter should default true or null. The provider defaults to true, but if the module defaults to true, it might override any manual value the user set previously.

morgante commented 3 years ago

We'd be happy to look at a PR. The default should probably be null.