terraform-google-modules / terraform-google-cloud-nat

Creates and configures Cloud NAT
https://registry.terraform.io/modules/terraform-google-modules/cloud-nat/google
Apache License 2.0
81 stars 68 forks source link

feat(bgp-settings): add keepalive interval #67

Closed aorfanos closed 2 years ago

aorfanos commented 2 years ago

Recent runs with this module display the following message

bgp {
    keepalive_interval = 0 -> 20
    # (3 unchanged attributes hidden)
}

This change sets the default as per the docs and allows for customization.

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

For more information, open the CLA check for this pull request.

comment-bot-dev commented 2 years ago

Thanks for the PR! πŸš€ Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

Error: Unsupported argument β”‚

β”‚

on main.tf line 42, in resource "google_compute_router" "router": β”‚

42:
keepalive = var.router_bgp_keepalive β”‚

β”‚

An argument named "keepalive" is not expected here. β•΅ terraform_validate ./examples/advanced β•· β”‚

Error: Unsupported argument β”‚

β”‚

on ../../main.tf line 42, in resource "google_compute_router" "router": β”‚

42:
keepalive = var.router_bgp_keepalive β”‚

β”‚

An argument named "keepalive" is not expected here. β•΅ terraform_validate ./examples/basic β•· β”‚

Error: Unsupported argument β”‚

β”‚

on ../../main.tf line 42, in resource "google_compute_router" "router": β”‚

42:
keepalive = var.router_bgp_keepalive β”‚

β”‚

An argument named "keepalive" is not expected here. β•΅ terraform_validate ./examples/nat_with_compute_engine Success! The configuration is valid. terraform_validate ./examples/nat_with_gke Success! The configuration is valid. terraform_validate ./test/fixtures/advanced β•· β”‚

Error: Unsupported argument β”‚

β”‚

on ../../../main.tf line 42, in resource "google_compute_router" "router": β”‚

42:
keepalive = var.router_bgp_keepalive β”‚

β”‚

An argument named "keepalive" is not expected here. β•΅ terraform_validate ./test/fixtures/basic β•· β”‚

Error: Unsupported argument β”‚

β”‚

on ../../../main.tf line 42, in resource "google_compute_router" "router": β”‚

42:
keepalive = var.router_bgp_keepalive β”‚

β”‚

An argument named "keepalive" is not expected here. β•΅ terraform_validate ./test/fixtures/subnetworks β•· β”‚

Error: Unsupported argument β”‚

β”‚

on ../../../main.tf line 42, in resource "google_compute_router" "router": β”‚

42:
keepalive = var.router_bgp_keepalive β”‚

β”‚

An argument named "keepalive" is not expected here. β•΅ terraform_validate ./test/setup Success! The configuration is valid.