terraform-google-modules / terraform-google-cloud-nat

Creates and configures Cloud NAT
https://registry.terraform.io/modules/terraform-google-modules/cloud-nat/google
Apache License 2.0
81 stars 68 forks source link

feat: add tcp time wait timeout variable #77

Closed hcavarsan closed 2 years ago

hcavarsan commented 2 years ago

add new variable to set TCP time wait timeout

closes https://github.com/terraform-google-modules/terraform-google-cloud-nat/issues/72

google-cla[bot] commented 2 years ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

comment-bot-dev commented 2 years ago

@hcavarsan Thanks for the PR! πŸš€ Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

Error: Unsupported argument β”‚

β”‚

on main.tf line 59, in resource "google_compute_router_nat" "main": β”‚

59:
tcp_time_wait_timeout_sec = var.tcp_time_wait_timeout_sec β”‚

β”‚

An argument named "tcp_time_wait_timeout_sec" is not expected here. β•΅ terraform_validate ./examples/advanced β•· β”‚

Error: Unsupported argument β”‚

β”‚

on ../../main.tf line 59, in resource "google_compute_router_nat" "main": β”‚

59:
tcp_time_wait_timeout_sec = var.tcp_time_wait_timeout_sec β”‚

β”‚

An argument named "tcp_time_wait_timeout_sec" is not expected here. β•΅ terraform_validate ./examples/basic β•· β”‚

Error: Unsupported argument β”‚

β”‚

on ../../main.tf line 59, in resource "google_compute_router_nat" "main": β”‚

59:
tcp_time_wait_timeout_sec = var.tcp_time_wait_timeout_sec β”‚

β”‚

An argument named "tcp_time_wait_timeout_sec" is not expected here. β•΅ terraform_validate ./examples/nat_with_compute_engine Success! The configuration is valid. terraform_validate ./examples/nat_with_gke Success! The configuration is valid. terraform_validate ./test/fixtures/advanced β•· β”‚

Error: Unsupported argument β”‚

β”‚

on ../../../main.tf line 59, in resource "google_compute_router_nat" "main": β”‚

59:
tcp_time_wait_timeout_sec = var.tcp_time_wait_timeout_sec β”‚

β”‚

An argument named "tcp_time_wait_timeout_sec" is not expected here. β•΅ terraform_validate ./test/fixtures/basic β•· β”‚

Error: Unsupported argument β”‚

β”‚

on ../../../main.tf line 59, in resource "google_compute_router_nat" "main": β”‚

59:
tcp_time_wait_timeout_sec = var.tcp_time_wait_timeout_sec β”‚

β”‚

An argument named "tcp_time_wait_timeout_sec" is not expected here. β•΅ terraform_validate ./test/fixtures/subnetworks β•· β”‚

Error: Unsupported argument β”‚

β”‚

on ../../../main.tf line 59, in resource "google_compute_router_nat" "main": β”‚

59:
tcp_time_wait_timeout_sec = var.tcp_time_wait_timeout_sec β”‚

β”‚

An argument named "tcp_time_wait_timeout_sec" is not expected here. β•΅ terraform_validate ./test/setup Success! The configuration is valid.