terraform-google-modules / terraform-google-cloud-storage

Creates one or more Cloud Storage buckets and assigns basic permissions on them to arbitrary users
https://registry.terraform.io/modules/terraform-google-modules/cloud-storage/google
Apache License 2.0
169 stars 558 forks source link

simple bucket creation ignores values #334

Closed rpmduarte closed 2 months ago

rpmduarte commented 2 months ago

TL;DR

When you use the variable, admins, bucket_admins, or readers, bucket_readers and you execute a new terraform plan/apply it doesn't detect any changes and does absolutely nothing

Expected behavior

I would expect the IAM principals to get the roles applied

Observed behavior

nothing, terraform says no changes detected

Terraform Configuration

module "blabla" {
  source   = "terraform-google-modules/cloud-storage/google"
  version  = "~> 6.0"
  location = local.location

  project_id       = local.project
  prefix           = random_string.prefix.result
  names            = ["blabla"]
  randomize_suffix = false
  bucket_viewers = {
    costandcharges = "serviceaccount:blabla@projectx.iam.gserviceaccount.com"
  }
  admins = ["user:me@org.net", "group:foo-admins@example.com"]

  autoclass = {
    blabla = true
  }

  labels = local.labels
}

Terraform Version

Terraform v1.7.4

Additional information

No response

rpmduarte commented 2 months ago

I didn't see the set_admin_role variable...