terraform-google-modules / terraform-google-group

Manages Google Groups
https://registry.terraform.io/modules/terraform-google-modules/group/google
Apache License 2.0
43 stars 27 forks source link

Support for changing group labels #42

Closed Shaked closed 1 year ago

Shaked commented 1 year ago

When creating a new group or maintaining an existing one, there's a need to decide which type of group we would like to support. GCP allows the usage of two: DISCUSSION and SECURITY. Currently, it's not possible to decide which labels to use and GCP doesn't allow removing existing labels, therefore once a group is marked with either of the above, there's no way to apply terraform anymore.

This PR helps overcome the issue of existing labels and also exposes a new feature - support to add a security group.

Usage example:

module "group" {
  for_each     = { for group in local.group_members : group.group_name => group }
  source       = "terraform-google-modules/group/google"
  version      = "~> 0.1"
  customer_id  = local.customer_id
  id           = "${each.value.group_name}@${local.google_domain}"
  display_name = each.value.display_name
  description  = each.value.description
  members      = each.value.members
  label_keys = [
    "default",
    "security",
  ]
}
google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

comment-bot-dev commented 1 year ago

Thanks for the PR! 🚀 Unfortunately it looks like some of our CI checks failed. See the Contributing Guide for details.

github-actions[bot] commented 1 year ago

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days