search

terraform-google-modules / terraform-google-iam

Manages multiple IAM roles for resources on Google Cloud
https://registry.terraform.io/modules/terraform-google-modules/iam/google
Apache License 2.0
189 stars 171 forks source link

feat(cloud run service iam): :sparkles: cloud run services iam submodule #164

Closed rs1986x closed 1 year ago

rs1986x commented 1 year ago

Hello! this is a IAM module for cloud run services, hope you find it useful

comment-bot-dev commented 1 year ago

Thanks for the PR! 🚀
✅ Lint checks have passed.

rs1986x commented 1 year ago

i can't seem to pass the cicd build, can somebody share the error output so i can address it? thanks

rs1986x commented 1 year ago

Hello! would it be possible to get a feedback on this please? many thanks 😄

apeabody commented 1 year ago

Hi @rs1986x, thanks for the contribution! It appears there is an error in the Custom Role integration tests:

  ×  GCP Custom Role: Custom Role (1 failed)
     ×  Command: `gcloud iam roles describe customDatastoreViewer_525f --organization 943740911108 --format=json` project_unsupported_custom_role does not have permissions
     expected ["gkehub.features.get", "gkehub.features.getIamPolicy", "gkehub.features.list", "gkehub.locations.get...ons.get", "gkehub.operations.list", "resourcemanager.projects.get", "resourcemanager.projects.list"] not to include "gkehub.features.list"
andrewmackett commented 1 year ago

Heads up that there are some copy/paste typos in the two README.md files that refer to PubSub Topic.

rs1986x commented 1 year ago

Hi @rs1986x, thanks for the contribution! It appears there is an error in the Custom Role integration tests:

  ×  GCP Custom Role: Custom Role (1 failed)
     ×  Command: `gcloud iam roles describe customDatastoreViewer_525f --organization 943740911108 --format=json` project_unsupported_custom_role does not have permissions
     expected ["gkehub.features.get", "gkehub.features.getIamPolicy", "gkehub.features.list", "gkehub.locations.get...ons.get", "gkehub.operations.list", "resourcemanager.projects.get", "resourcemanager.projects.list"] not to include "gkehub.features.list"

Hi @apeabody thanks for your answer. Could you help me understand where the error is? when i did create the PR, I applied the example in a dev project and worked out of the box, i don't know how to run all your suite of tests now why is the pipeline failing but i would like to understand. I am not sure i know how to fix the integration tests.

@andrewmackett thanks for the comment i will fix that right away 😄

apeabody commented 1 year ago

Thanks for the contribution @rs1986x - Looks like the error might have been transitory and all the checks have now passed. :)

rs1986x commented 1 year ago

Thanks @apeabody! my pleasure