terraform-google-modules / terraform-google-iam

Manages multiple IAM roles for resources on Google Cloud
https://registry.terraform.io/modules/terraform-google-modules/iam/google
Apache License 2.0
189 stars 170 forks source link

Submodule custom_roles_iam change permission and member field to optional #194

Closed minzetaos closed 1 year ago

minzetaos commented 1 year ago

TL;DR

When user defines a role using base_roles field, there is actually no need to have a redundant permission field. Also, there is no need to force user to add member, when creating a role

Terraform Resources

No response

Detailed design

Just need to simply add default = [] in variables.tf to these two variables I mentioned above and problem solved.

variable "permissions" {
  type        = list(string)
  description = "IAM permissions assigned to Custom Role."
  default     = []
}

variable "members" {
  description = "List of members to be added to custom role."
  type        = list(string)
  default     = []
}

Additional information

No response