terraform-google-modules / terraform-google-iam

Manages multiple IAM roles for resources on Google Cloud
https://registry.terraform.io/modules/terraform-google-modules/iam/google
Apache License 2.0
189 stars 170 forks source link

feat: set permissions and member field optional in custom-role sub-module #195

Closed imrannayer closed 1 year ago

imrannayer commented 1 year ago

Fix #194

bharathkkb commented 1 year ago

/gcbrun

imrannayer commented 1 year ago

@imrannayer - PTAL at my comment if its reasonable.

@g-awmalik cross variable validation is not supported in Terraform yet. I can add a check locally and only allow resource creation when either one of them is non-empty list but that will not make it clear to the user why resources are not creating.

g-awmalik commented 1 year ago

I see. We can let go this for now but it'll be nice if this can be made into an object instead with two attributes. That way we can check if at least one attribute is set.

imrannayer commented 1 year ago

@g-awmalik can you plz merge. I dont have permission on this repo.