This PR uses an approach that creates a breaking change in projects_iam submodule by deprecating var.project. From my understanding, the projects and project variables in the projects_iam submodule are redundant. Passing in a single project_id in var.projects will handle both static and dynamic use cases. This would also fit the input pattern all the other submodules use (e.g var.storage_buckets, var.subnets). However, if there's a use case for keeping var.project, please let me know and I can take a different approach.
Changes:
Remove var.entity from helper
Remove var.project from project_iam
Add fixture that passes in an empty list of subnets
We need to preserve var.project or at least otherwise verify that in the case of a dynamically generated project ID the module still works. Can you test/confirm that?
Yes I modified a test that dynamically gets a generated project ID and passes it into var.projects which passes. Another existing test that uses dynamically generated project IDs in authoritative mode also passes. Would these tests suffice?
Fixes #93
This PR supports empty lists for all submodules.
This PR uses an approach that creates a breaking change in
projects_iam
submodule by deprecatingvar.project
. From my understanding, the projects and project variables in the projects_iam submodule are redundant. Passing in a single project_id invar.projects
will handle both static and dynamic use cases. This would also fit the input pattern all the other submodules use (e.gvar.storage_buckets
,var.subnets
). However, if there's a use case for keepingvar.project
, please let me know and I can take a different approach.Changes:
var.entity
from helpervar.project
from project_iamAlso Fixes #96 by updating documentation