Initial module implementation

terraform-google-modules / terraform-google-jenkins

Creates a Compute Engine instance running Jenkins

Apache License 2.0

31 stars 69 forks source link

Closed Jberlinsky closed 5 years ago

Jberlinsky commented 5 years ago

Notable design decisions that need addressing, but shouldn't prevent an initial implementation:

[ ] The module currently creates a jenkins service account, and does not allow a user-created one to be passed in. This should probably follow a similar pattern to the one proposed in https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/issues/2

TODO

[x] Docker image management needs to be updated to our new standards (see GKE & project-factory modules)

adrienthebo commented 5 years ago

@Jberlinsky checking in - would you like me to do another review pass or would you like to get more work on it first?

Jberlinsky commented 5 years ago

@adrienthebo Working on the current tranche of feedback now -- I'll ping you shortly for re-review :)

Jberlinsky commented 5 years ago

@adrienthebo Might I suggest that we extract concerns related to shared VPCs to a separate PR, and proceed with reviewing this one as it stands?

Jberlinsky commented 5 years ago

@adrienthebo Ready for one more pass :)

Jberlinsky commented 5 years ago

Pinging @morgante

Jberlinsky commented 5 years ago

@morgante I've address the issues mentioned here, would appreciate if you could take a final look so we can get this PR merged in!