Closed Jberlinsky closed 5 years ago
@Jberlinsky checking in - would you like me to do another review pass or would you like to get more work on it first?
@adrienthebo Working on the current tranche of feedback now -- I'll ping you shortly for re-review :)
@adrienthebo Might I suggest that we extract concerns related to shared VPCs to a separate PR, and proceed with reviewing this one as it stands?
@adrienthebo Ready for one more pass :)
Pinging @morgante
@morgante I've address the issues mentioned here, would appreciate if you could take a final look so we can get this PR merged in!
Notable design decisions that need addressing, but shouldn't prevent an initial implementation:
jenkins
service account, and does not allow a user-created one to be passed in. This should probably follow a similar pattern to the one proposed in https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/issues/2TODO