Fixes #8, fixes #9, fixes #10, fixes #11

ingwarr commented 5 years ago

Fixes https://github.com/terraform-google-modules/terraform-google-jenkins/issues/8 fixes https://github.com/terraform-google-modules/terraform-google-jenkins/issues/9 fixes https://github.com/terraform-google-modules/terraform-google-jenkins/issues/10 fixes https://github.com/terraform-google-modules/terraform-google-jenkins/issues/11 fixes https://github.com/terraform-google-modules/terraform-google-jenkins/issues/13

ingwarr commented 5 years ago

All tests passed:

ingwarr commented 5 years ago

It can't work without test/fixtures/terraform.tfvars, I'll refactor build script, it related only to CI

ingwarr commented 5 years ago

@aaron-lane As I see it newer run before, api is not active Error: Error enabling service: failed to issue request: googleapi: Error 403: Service Usage API has not been used in project 978467814094 before or it is disabled. Enable it by visiting https://console.cloud.google.com/apis/api/serviceusage.googleapis.com/overview?project=978467814094 then retry. If you enabled this API recently, wait a few minutes for the action to propagate to our systems and retry., accessNotConfigured

     on ../../../examples/simple_example/main.tf line 21, in resource "google_project_service" "cloudresourcemanager":
     21: resource "google_project_service" "cloudresourcemanager" {

   Error: googleapi: Error 403: phoogle-ci-jenkins-id@phoogle-ci-jenkins-project.iam.gserviceaccount.com does not have storage.buckets.create access to project 978467814094., forbidden

     on ../../../examples/simple_example/main.tf line 38, in resource "google_storage_bucket" "artifacts":
     38: resource "google_storage_bucket" "artifacts" {

ocervell commented 5 years ago

LGTM

terraform-google-modules / terraform-google-jenkins

Fixes #8, fixes #9, fixes #10, fixes #11 #12