search

terraform-google-modules / terraform-google-kubernetes-engine

Configures opinionated GKE clusters
https://registry.terraform.io/modules/terraform-google-modules/kubernetes-engine/google
Apache License 2.0
1.13k stars 1.16k forks source link

Anthos Service Mesh integration in beta-private-cluster module #1031

Open carlosbmg opened 2 years ago

carlosbmg commented 2 years ago

Hello,

it seems GCP is deprecating the Istio enable option for the GKE clusters as shown in the picture drawing

Is there an alternative already planned for the beta-private-cluster module to include Anthos Service Mesh declaratively? It is already there for istio as a flag. Although Anthos have already a sub-module, they're not embedded in the beta-private-cluster capabilities.

Maybe also someone can provided insight if you're creating a Multi-Tenancy cluster using Anthos instead of Istio, did you use the anthos sub-module. I'm behind of trying, but wanted to know what the community approach is.

Thanks in advance.

PsychoSid commented 2 years ago

Hello - yes we use the asm sub module with the beta-private-cluster one as the add-on was so far behind it worked just fine.

Or we did as the latest version of ASM has a different installer than the one in the module at this time :)

morgante commented 2 years ago

I do indeed recommend using the ASM submodule instead of enabling Istio. In fact, we'll be removing the istio option soon.

In Q4, we are hoping to refactor the ASM submodule to make it more declarative. As part of that refactor, we can consider embedding it in the beta-private-cluter submodule. But it should be fine to use them side by side as well.

carlosbmg commented 2 years ago

Hello @morgante and @PsychoSid Sorry for the late reply.

Thanks a lot for your answers. I'll test the ASM sub module next week, as i was using the istio enabling feature till now...

I think it'll be a great idea to have this in the same beta-private-cluster tho.

github-actions[bot] commented 2 years ago

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

hSATAC commented 2 years ago

Is the refactor of ASM module of making it more declarative happened? We're too using he beta-private-cluster, upgraded to ASM recently and looking for a way to import it into our terraform.

brantgurga commented 2 years ago

@hSATAC that refactor happened in v20.0.0. It only supports managed ASM now, and I've only had it work with that or with asmcli with an in-project fleet. I haven't successfully seen a cross-project provision. The manifest applies and just sits there and whatever processes it never processes it. My issue could be a networking or other connectivity issue still being new to Kubernetes and GKE, but that's the experience so far.