search

terraform-google-modules / terraform-google-kubernetes-engine

Configures opinionated GKE clusters
https://registry.terraform.io/modules/terraform-google-modules/kubernetes-engine/google
Apache License 2.0
1.11k stars 1.13k forks source link

Install In cluster ASM on GKE #1201

Open mpsanj opened 2 years ago

mpsanj commented 2 years ago

TL;DR

Not seeing an option to specify the ASM version and choose incluster ASM install

https://registry.terraform.io/modules/terraform-google-modules/kubernetes-engine/google/latest/submodules/asm

Terraform Resources

No response

Detailed design

Managed ASM doesn't support:

1. Shipping of telemetry data including tracing solutions like Lightstep 

2. In Managed ASM Locality based routing is only available in Regular and Rapid release channels, we want go with Stable release channel for our prod GKE cluster

Additional information

Is there a way where TF modules can support In cluster ASM installation ?

bharathkkb commented 2 years ago

@Monkeyanator do we have plans for this?

morgante commented 2 years ago

We do not currently plan to support in-cluster install and recommend migrating to the Google managed control plane.

mpsanj commented 2 years ago

Thanks for addressing it quickly.

Is there any workaround for shipping telemetry data to Jaeger, Lightstep etc in managed ASM ? Which release channel of managed anthos is recommended for a Production GKE cluster (stable release channel) ?

frits-v commented 2 years ago

@mpsanj you can configure alternative tracing using Istio Telemetry API https://istio.io/latest/docs/reference/config/telemetry

mark6628 commented 2 years ago

Is it not on the roadmap at the moment? or we can expect it later?

Many customer still are using incluster anthos control plane rather then going with managed one?

On Thu, 7 Apr 2022 at 21:59, Morgante Pell @.***> wrote:

We do not currently plan to support in-cluster install and recommend migrating to the Google managed control plane.

— Reply to this email directly, view it on GitHub https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/issues/1201#issuecomment-1091958308, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHH4YTB6CIYHEHXM5M6KPLDVD4EPFANCNFSM5SYV7GUA . You are receiving this because you are subscribed to this thread.Message ID: <terraform-google-modules/terraform-google-kubernetes-engine/issues/1201/1091958308 @github.com>

bharathkkb commented 2 years ago

@mark6628 currently we do not have plans for supporting in cluster. I will leave this issue open as a FR to gauge interest.

mark6628 commented 1 year ago

Thanks for your help in keeping this open. Certainly we shall keep both options available as a part of module reason being google supports both of them and customers base is more in Incluster as compare to Managed one and let customer choose which one they want to use.

Earlier when we use to install using install_asm then it was supported as well having both options.

On Tue, 24 May 2022 at 21:58, Bharath KKB @.***> wrote:

@mark6628 https://github.com/mark6628 currently we do not have plans for supporting in cluster. I will leave this issue open as a FR to gauge interest.

— Reply to this email directly, view it on GitHub https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/issues/1201#issuecomment-1136142125, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHH4YTHUGZJ66R44SFPOPBLVLT7T5ANCNFSM5SYV7GUA . You are receiving this because you were mentioned.Message ID: <terraform-google-modules/terraform-google-kubernetes-engine/issues/1201/1136142125 @github.com>