search

terraform-google-modules / terraform-google-kubernetes-engine

Configures opinionated GKE clusters
https://registry.terraform.io/modules/terraform-google-modules/kubernetes-engine/google
Apache License 2.0
1.15k stars 1.17k forks source link

fix: fix typo in kube-dns-upstream-nameservers configmap #2149

Closed MaximF closed 1 month ago

MaximF commented 1 month ago

Fix typo for a configmap resource name from kube-dns-upstream-namservers to kube-dns-upstream-nameservers.

google-cla[bot] commented 1 month ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

MaximF commented 1 month ago

@apeabody Thanks for referencing. I made the change to the template and regenerated all the dependencies. Please take a look.

apeabody commented 1 month ago

/gcbrun

apeabody commented 1 month ago

Hi @MaximF - What will be the impact to current users? Would it make sense to include: https://developer.hashicorp.com/terraform/language/v1.3.x/moved

apeabody commented 1 month ago

/gcbrun

MaximF commented 1 month ago

Thanks @apeabody. I just added a moved block there.

apeabody commented 1 month ago

/gcbrun

apeabody commented 1 month ago

/gcbrun