search

terraform-google-modules / terraform-google-lb-http

Creates a global HTTP load balancer for Compute Engine by using forwarding rules
https://registry.terraform.io/modules/terraform-google-modules/lb-http/google
Apache License 2.0
319 stars 366 forks source link

feat: Add creating serverless negs inside module/serverless-negs itself #438

Closed q2w closed 3 months ago

q2w commented 4 months ago

This PR makes below changes,

  1. Adds a new field for backend called serverless_neg_backends. This field is used to configure serverless services like cloud-run, cloud-functions and app-engine as backend.
  2. The serverless-negs module creates google_compute_region_network_endpoint_group for serverless services within the module itself.
  3. Add a new example for cloud-run with implicit serverless neg creation within load balancer module
bharathkkb commented 4 months ago

/gcbrun

imrannayer commented 3 months ago

@q2w thx for the PR. Instead of updating existing example is it possible if you can add another module call which creates NEG? In this way we will keep testing both features of the module?

q2w commented 3 months ago

@q2w thx for the PR. Instead of updating existing example is it possible if you can add another module call which creates NEG? In this way we will keep testing both features of the module?

@imrannayer I have updated this PR with suggested changes. But before reviewing this PR, please have a look at this PR for fixing the test failure for this blueprint. Once the PR is merged i will rebase this PR.

q2w commented 3 months ago

@q2w thx for the PR. Instead of updating existing example is it possible if you can add another module call which creates NEG? In this way we will keep testing both features of the module?

@imrannayer I have updated this PR with suggested changes. But before reviewing this PR, please have a look at this PR for fixing the test failure for this blueprint. Once the PR is merged i will rebase this PR.

@imrannayer @bharathkkb The other PR is merged. Please review!

q2w commented 3 months ago

/gcbrun

q2w commented 3 months ago

/gcbrun

q2w commented 3 months ago

@imrannayer Please have a look!

bharathkkb commented 3 months ago

Discussed with @imrannayer offline and lgtm to merge