Dedicated firewall rules module + adding to top level module

[umairidris]

Currently the only CFT module to create firewall rules seems to be https://github.com/terraform-google-modules/terraform-google-network/tree/master/modules/fabric-net-firewall.

This seems to create a few default firewall rules and also needs to be a separate module call.

There is functionality to create custom rules. Would you be willing to accept a PR that pulls the custom rules logic out to its own submodule and adds it under the top level network module? Thus it would allow a user to create a network with custom firewall rules from one call.

[morgante]

Yeah I think we need to refactor the firewall rules module a bit. Here's what I'd like to see:

1. Split the core rules logic into its own submodule
2. Put the default rules in a submodule (which calls the core rules module)
3. Add a reference to (1) from the root module.

[github-actions[bot]]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

[morgante]

Still needs to happen.

[imrannayer]

I think sub-module firewall-rules covers it.