Closed q2w closed 1 month ago
/gcbrun
@q2w @bharathkkb how are we going to handle this sub-module and current sub-module?
They both are same. Although Current module has a flaw that it accepts one IP address instead of list of ip addresses.
@q2w @bharathkkb how are we going to handle this sub-module and current sub-module?
They both are same. Although Current module has a flaw that it accepts one IP address instead of list of ip addresses.
@imrannayer Thanks for pointing to the current module! Before creating this PR i tried to check if some module exist which can create service networking. I missed finding out private_service_access sub-module. IMHO the current submodule can fulfill the requirements. In future we can update the current module to take multiple addresses. I would defer to @bharathkkb for final call on the current PR.
Good catch @imrannayer, yes let's close this and update current module as Imran pointed out. Sorry for the churn @q2w!
This PR makes below changes,