search

terraform-google-modules / terraform-google-network

Sets up a new VPC network on Google Cloud
https://registry.terraform.io/modules/terraform-google-modules/network/google
Apache License 2.0
417 stars 1.23k forks source link

feat: Add new submodule for service networking #569

Closed q2w closed 1 month ago

q2w commented 2 months ago

This PR makes below changes,

  1. Adds a new submodule for service-networking
  2. Adds new example and test for the submodule
imrannayer commented 1 month ago

/gcbrun

imrannayer commented 1 month ago

@q2w @bharathkkb how are we going to handle this sub-module and current sub-module?

They both are same. Although Current module has a flaw that it accepts one IP address instead of list of ip addresses.

q2w commented 1 month ago

@q2w @bharathkkb how are we going to handle this sub-module and current sub-module?

They both are same. Although Current module has a flaw that it accepts one IP address instead of list of ip addresses.

@imrannayer Thanks for pointing to the current module! Before creating this PR i tried to check if some module exist which can create service networking. I missed finding out private_service_access sub-module. IMHO the current submodule can fulfill the requirements. In future we can update the current module to take multiple addresses. I would defer to @bharathkkb for final call on the current PR.

bharathkkb commented 1 month ago

Good catch @imrannayer, yes let's close this and update current module as Imran pointed out. Sorry for the churn @q2w!