terraform-google-modules / terraform-google-org-policy

Manages Google Cloud organization policies
https://registry.terraform.io/modules/terraform-google-modules/org-policy/google
Apache License 2.0
79 stars 79 forks source link

fix: specify rules variable type in org_policy_v2 #73

Closed malhussan closed 1 year ago

malhussan commented 1 year ago

Without this change Terraform would throw an error because it's unable to infer types.

The issue is similar to https://github.com/hashicorp/terraform/issues/30592#issuecomment-1183689596, and its fix is by adding a type constraint.

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

prabhu34 commented 1 year ago

LGTM cc @prabhu34 for another pass

LGTM. Should rebase with main before the merge.

comment-bot-dev commented 1 year ago

@malhussan Thanks for the PR! 🚀
✅ Lint checks have passed.