search

terraform-google-modules / terraform-google-project-factory

Creates an opinionated Google Cloud project by using Shared VPC, IAM, and Google Cloud APIs
https://registry.terraform.io/modules/terraform-google-modules/project-factory/google
Apache License 2.0
825 stars 533 forks source link

Fix tests #105

Closed morgante closed 5 years ago

morgante commented 5 years ago

The CI tests merged still have outstanding issues:

aaron-lane commented 5 years ago

Still broken on master: https://concourse.infra.cft.tips/teams/cft/pipelines/terraform-google-project-factory/jobs/integration-tests/builds/395#L5cb98c2e:505.

aaron-lane commented 5 years ago

I've looked in to this issue more.

The malformed group_email output is part of the minimal suite, not the full suite. The minimal suite does not use a G Suite group which is why this broken output is not causing a failure. The fix for this issue should be in the gsuite_group module, specifically at this line. If var.name is empty then local.email should also be empty. The associated integration test in the minimal suite should confirm that group_email is empty.

alexkonkin commented 5 years ago

Thank you for your review. I will remove my test from the full test suite and rewrite it according to the approach that you mentioned in your previous reply