terraform-google-modules / terraform-google-project-factory

Creates an opinionated Google Cloud project by using Shared VPC, IAM, and Google Cloud APIs
https://registry.terraform.io/modules/terraform-google-modules/project-factory/google
Apache License 2.0
827 stars 535 forks source link

Expand testing to cover G Suite functionality #111

Open morgante opened 5 years ago

morgante commented 5 years ago

The tests currently don't make it easy to test G Suite-related functionality in the module.

We should add fixtures to consistently exercise the create_group and API/SA group functionalities.

morgante commented 5 years ago

We also need tests covering the various scenarios documented here.

thefirstofthe300 commented 5 years ago

Just to reiterate, the scenarios that need to be tested are:

Also

aaron-lane commented 4 years ago

We will need to alter the test setup to support a long-lived service account, or identify an alternative approach to satisfy the authentication requirements of the G Suite provider.

morgante commented 4 years ago

Here's how I suggest we tackle this:

aaron-lane commented 4 years ago

I think that sounds like a good approach. I suggest that we maintain the setup configuration so contributors can continue to easily create a test environment for the minimal suite, and push the exceptional logic in to the build configuration file. May be add a separate "full-ci-setup" configuration which does what you propose.

morgante commented 4 years ago

Sure, we could have a separate folder which behaves similarly but is only used for CI.