API Page size too small

[leone145]

During preconditions check, if the seed project has a large number of APIs enabled, the python precondition check cannot page and preconditions fail. Suggest increasing the pageSize option as below.

        parent = "projects/" + self.project_id
        request = service.services().list(
            parent=parent,
            filter='state:ENABLED',
            pageSize='200'
        )

Error observed that led to the discovery. ': exit status 1. Output: [ { "type": "Required APIs on service account project", "name": "projects/project-abc123", "satisfied": [ "cloudresourcemanager.googleapis.com", "appengine.googleapis.com", "cloudbilling.googleapis.com", "admin.googleapis.com" ], "unsatisfied": [ "iam.googleapis.com" ] },

[leone145]

Second suggestion would be to use services().get instead of services().list

        enabled = []
        for r in self.REQUIRED_APIS:
            request = service.services().get(
                name="projects/" + self.project_id + "/services/" + r
            )

            response = request.execute()

            if response['state'] == "ENABLED":
                enabled.append(r)

[morgante]

Thanks, good catch. We'd be happy to look at a PR for either fix.

[aaron-lane]

Fixed by #220.