terraform-google-modules / terraform-google-project-factory

Creates an opinionated Google Cloud project by using Shared VPC, IAM, and Google Cloud APIs
https://registry.terraform.io/modules/terraform-google-modules/project-factory/google
Apache License 2.0
826 stars 535 forks source link

fix: grant compute.networkAdmin for Datastream SA by default #833

Closed dtsong closed 9 months ago

dtsong commented 1 year ago

Intend to fix: https://github.com/terraform-google-modules/terraform-google-project-factory/issues/831

Per the docs, in a shared VPC context, the host project will need to grant compute.networkAdmin to the child project's Datastream service account to support private connectivity.

Screen Shot 2023-08-26 at 7 24 20 PM

Source: https://cloud.google.com/datastream/docs/create-a-private-connectivity-configuration#before-you-begin

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

imrannayer commented 12 months ago

@dtsong we dont assign admin permissions by default. Maybe we can add in variable definition that this is required for datastream.

github-actions[bot] commented 9 months ago

This PR is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days